Closed
Conversation
Copilot
AI
changed the title
[WIP] Refine StatefulPlanner.plan implementation
Refine Jan 30, 2026
StatefulPlanner.plan
There was a problem hiding this comment.
Pull request overview
This PR refactors the StatefulPlanner.cpp file by removing unused includes, cleaning up debugging code, and reorganizing method definitions for better code maintainability.
Changes:
- Removed unused header includes (CallbackSink, Exchange, HashBuild, Merge, NestedLoopJoinBuild, RoundRobinPartitionFunction)
- Cleaned up debugging statements and simplified error handling
- Relocated
transformGenericOperatormethod to improve code organization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| VELOX_CHECK(extended, "Unsupported plan node: {}", planNode->toString()); | ||
| std::unique_ptr<exec::Operator> extended = exec::Operator::fromPlanNode(ctx_, nextOperatorId(), planNode); | ||
| VELOX_CHECK(extended, "Unsupported plan node: {}\n{}", planNode->toString(), process::StackTrace().toString()); |
There was a problem hiding this comment.
The error message includes a stack trace in the formatted output, but this could be verbose and difficult to read inline. Consider logging the stack trace separately or providing a more concise error message that directs users to additional logging for details.
Suggested change
| VELOX_CHECK(extended, "Unsupported plan node: {}\n{}", planNode->toString(), process::StackTrace().toString()); | |
| VELOX_CHECK(extended, "Unsupported plan node: {}", planNode->toString()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the
StatefulPlanner.planmethod implementation. No specific changes have been documented yet as the comment received only contained a mention without actionable feedback.The last 4 commits show:
Further context or specific requirements needed to complete the PR description.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.